Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20506 )
Change subject: IMPALA-12465: Partial unicode column name support ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@948 PS3, Line 948: public static boolean validateColumnName(String name) { nit: indentation doesn't match other functions or the comment. http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/20506/3/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@961 PS3, Line 961: public static boolean validateColumnName(String name) { nit: indentation doesn't match other functions or the comment. -- To view, visit http://gerrit.cloudera.org:8080/20506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ad9d63ac1b9631a0f4a433798bd5109aa2ed718 Gerrit-Change-Number: 20506 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Oct 2023 17:43:24 +0000 Gerrit-HasComments: Yes
