k.venureddy2...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20486 )
Change subject: IMPALA-12356: Alter partition event from hive is treated as self event ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20486/6//COMMIT_MSG@9 PS6, Line 9: : transa > Can you answer this question? Yes. This issue happens only with dynamic partition insert. Not with alter table add partition. http://gerrit.cloudera.org:8080/#/c/20486/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20486/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4537 PS8, Line 4537: params.get(MetastoreEventPropertyKey.CATALOG_SERVICE_ID.getKey()))) { > Should we check whether the key 'CATALOG_SERVICE_ID' exists in the table pa No need to check explicitly. NPE doesn't happen since String.equals() returns false when anObject passed to it is null. http://gerrit.cloudera.org:8080/#/c/20486/8/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/20486/8/tests/metadata/test_event_processing.py@456 PS8, Line 456: assert [(new_part_location,)] == partitions > Can you also assert that the number of events processed before and after ch get_impala_partition_info() at line 455 executes the show partitions query on impala. So if alter cmd from hive(at line 451) is not applied on catalogd, the location returned would still be old location. I think, location check will suffice. -- To view, visit http://gerrit.cloudera.org:8080/20486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23c2affa3fe32c0b3843bff5e4c0018dce9060d3 Gerrit-Change-Number: 20486 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 06:59:32 +0000 Gerrit-HasComments: Yes
