Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20533 )
Change subject: PROTOTYPE: IMPALA-12463: Batch non-consecutive table events in the event processor ...................................................................... Patch Set 2: (4 comments) Thanks Joe to work on this. http://gerrit.cloudera.org:8080/#/c/20533/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20533/2//COMMIT_MSG@13 PS2, Line 13: could nit: could be http://gerrit.cloudera.org:8080/#/c/20533/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20533/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@343 PS2, Line 343: DropDatabaseEvent nit: DropDatabaseEvent or AlterDatabaseEvent http://gerrit.cloudera.org:8080/#/c/20533/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@364 PS2, Line 364: alterTable should be beforeTableEvent http://gerrit.cloudera.org:8080/#/c/20533/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@374 PS2, Line 374: alterTable afterTableEvent -- To view, visit http://gerrit.cloudera.org:8080/20533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I849c0306bc46080ee4059854f42d9c217a89b905 Gerrit-Change-Number: 20533 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 20:47:08 +0000 Gerrit-HasComments: Yes
