Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 )
Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles ...................................................................... Patch Set 4: Code-Review+1 (5 comments) Sorry for my late review. I just have some minor comments. We can merge this when they are resolved. http://gerrit.cloudera.org:8080/#/c/20439/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20439/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles nit: Add "Fix" in the title, i.e. IMPALA-12397: Fix NullPointerException in SHOW ROLES when there are no roles http://gerrit.cloudera.org:8080/#/c/20439/4/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java File fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java: http://gerrit.cloudera.org:8080/#/c/20439/4/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java@21 PS4, Line 21: import org.apache.impala.authorization.AuthorizationChecker; nit: unused import http://gerrit.cloudera.org:8080/#/c/20439/4/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java@28 PS4, Line 28: import org.apache.ranger.plugin.model.RangerPolicy; nit: unused import http://gerrit.cloudera.org:8080/#/c/20439/4/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java@32 PS4, Line 32: import java.util.List; nit: unused import http://gerrit.cloudera.org:8080/#/c/20439/4/fe/src/test/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManagerTest.java@59 PS4, Line 59: showRolesParams.setGrant_groupIsSet(true); nit: We can remove this. It is a no-op when using 'true'. Code snipper: public void setGrant_groupIsSet(boolean value) { if (!value) { this.grant_group = null; } } -- To view, visit http://gerrit.cloudera.org:8080/20439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id80fc2c9152a09194718da1b4266c5f804f0971f Gerrit-Change-Number: 20439 Gerrit-PatchSet: 4 Gerrit-Owner: ji chen <jichen0...@163.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 07 Oct 2023 05:52:36 +0000 Gerrit-HasComments: Yes
