Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20591 to look at the new patch set (#2). Change subject: IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header is received ...................................................................... IMPALA-12505: Define a new impala flag that runs the trusted domain check on the origin address if the trusted_domain_use_xff_header flag is enabled and no X-Forwarded-For header is received This change defines a new impala flag, which modifies the trusted domain check to work as follows if the trusted_domain and trusted_domain_use_xff_header flags are set: If there is an X-Forwarded-For header in the request, the trusted domain check runs to the value derived from it, if there is no such header, then the check runs to the origin (the address sending the request). Note: If there is an X-Forwarded-For header in the request or the trusted_domain_use_xff_header flag or trusted_domain flag is not set, then the behavior is not changed. Tested with new custom cluster tests. Change-Id: I58e5d1119527139eafaa411b55517b10bf394bb2 --- M be/src/rpc/authentication.cc M be/src/transport/THttpServer.cpp M be/src/util/webserver.cc M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java 5 files changed, 79 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/20591/2 -- To view, visit http://gerrit.cloudera.org:8080/20591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I58e5d1119527139eafaa411b55517b10bf394bb2 Gerrit-Change-Number: 20591 Gerrit-PatchSet: 2 Gerrit-Owner: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>