Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20595 )
Change subject: IMPALA-11387: Introduce virtual column to expose Iceberg's file-level data sequence number ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/20595/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20595/1//COMMIT_MSG@11 PS1, Line 11: From Iceberg docs: Could add a link to the Iceberg docs. http://gerrit.cloudera.org:8080/#/c/20595/1//COMMIT_MSG@17 PS1, Line 17: older sequence numbers Does this refer to the data sequence number or the file sequence number? http://gerrit.cloudera.org:8080/#/c/20595/1/be/src/exec/file-metadata-utils.cc File be/src/exec/file-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/20595/1/be/src/exec/file-metadata-utils.cc@72 PS1, Line 72: if Could be 'else if'. http://gerrit.cloudera.org:8080/#/c/20595/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-virtual-columns.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-virtual-columns.test: http://gerrit.cloudera.org:8080/#/c/20595/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-virtual-columns.test@187 PS1, Line 187: ==== Do you think it would be useful to add tests where we select the data sequence number through a view? Something like WITH w as ( select *, ICEBERG__DATA__SEQUENCE__NUMBER from ice_tbl_v2_part order by col_i) select * from w; Also, can we join tables based on ICEBERG__DATA__SEQUENCE__NUMBER? -- To view, visit http://gerrit.cloudera.org:8080/20595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id950e97782a2a29b505164470cfb646c5358dfca Gerrit-Change-Number: 20595 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:21:59 +0000 Gerrit-HasComments: Yes
