Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 )
Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying ...................................................................... Patch Set 14: (3 comments) Thanks for the refactorings! Left a few minor comments. http://gerrit.cloudera.org:8080/#/c/20010/14/be/src/exec/iceberg-metadata/iceberg-row-reader.cc File be/src/exec/iceberg-metadata/iceberg-row-reader.cc: http://gerrit.cloudera.org:8080/#/c/20010/14/be/src/exec/iceberg-metadata/iceberg-row-reader.cc@124 PS14, Line 124: void* slot = tuple->GetSlot(slot_desc->tuple_offset()); nit: this could also be done in MaterializeRow(). Then you could just pass 'slot' to the functions. 'slot_desc' and 'tuple' are not needed to pass anymore. http://gerrit.cloudera.org:8080/#/c/20010/13/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/20010/13/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@414 PS13, Line 414: UNPARTITIONED > This is for the scheduler, to execute the fragment on the coordinator. sche I see, could you please add a comment that explains this as it is not trivial? http://gerrit.cloudera.org:8080/#/c/20010/14/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/20010/14/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@364 PS14, Line 364: Can we have JOINs between metadata tables and the corresponding Iceberg table (e.g. using INPUT__FILE__NAME virtual column in the JOIN)? -- To view, visit http://gerrit.cloudera.org:8080/20010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e943cecd77f5ef7af7cd07e2b596f2c5b4331e7 Gerrit-Change-Number: 20010 Gerrit-PatchSet: 14 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <g.furnst...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Oct 2023 14:28:01 +0000 Gerrit-HasComments: Yes
