Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 )
Change subject: IMPALA-12156: Support High Availability for Statestore ...................................................................... Patch Set 16: (6 comments) http://gerrit.cloudera.org:8080/#/c/20372/15/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/20372/15/be/src/common/global-flags.cc@426 PS15, Line 426: DEFINE_int32(state_store_2_port, 24001, > Thoughts on moving these flags to the same location where their correspondi I prefer to put statestore server related flags in statestore.cc. http://gerrit.cloudera.org:8080/#/c/20372/15/be/src/common/global-flags.cc@432 PS15, Line 432: // TGeospatialLibrary's values are mapped here as constants > Given the existing flags are named '-state_store_host' and '-state_store_po Agree http://gerrit.cloudera.org:8080/#/c/20372/14/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/20372/14/be/src/statestore/statestore.cc@115 PS14, Line 115: // Flags for Statestore HA > Good point, I did some more investigating, and flag names definitely favor dropped the 'd' from statestore flag variables. http://gerrit.cloudera.org:8080/#/c/20372/15/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/20372/15/be/src/statestore/statestore.cc@122 PS15, Line 122: DEFINE_bool(statestore_force_active, false, "Set to true to force this statestored " > Please rename to 'statestore_force_active' renamed as 'statestore_force_active' http://gerrit.cloudera.org:8080/#/c/20372/15/be/src/statestore/statestore.cc@134 PS15, Line 134: DEFINE_int64(statestore_ha_preemption_wait_period_ms, 10000, "(Advanced) The time after " > Please rename to 'statestore_ha_preemption_wait_period_ms' renamed as 'statestore_force_active' http://gerrit.cloudera.org:8080/#/c/20372/15/be/src/statestore/statestore.cc@946 PS15, Line 946: G(INFO) << "Registering: " << subscriber_id; : bool is_reregistering = false; : { removed from patch #14. Brought back on patch #15 by mistake -- To view, visit http://gerrit.cloudera.org:8080/20372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87 Gerrit-Change-Number: 20372 Gerrit-PatchSet: 16 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 20 Oct 2023 01:17:50 +0000 Gerrit-HasComments: Yes
