Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 )
Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI ...................................................................... Patch Set 6: (2 comments) I could successfully run ./tests/run-js-tests.sh on my local machine. Just one minor comment. Please also fix "line too long (98 > 90)" warning in run-js-tests.sh. http://gerrit.cloudera.org:8080/#/c/20538/6/www/scripts/query_timeline/chart_commons.js File www/scripts/query_timeline/chart_commons.js: http://gerrit.cloudera.org:8080/#/c/20538/6/www/scripts/query_timeline/chart_commons.js@64 PS6, Line 64: var no_change; nit: don't need to define this variable out of loop, define it directly in line #66 http://gerrit.cloudera.org:8080/#/c/20538/4/www/scripts/tests/query_timeline/chart_commons.test.js File www/scripts/tests/query_timeline/chart_commons.test.js: http://gerrit.cloudera.org:8080/#/c/20538/4/www/scripts/tests/query_timeline/chart_commons.test.js@24 PS4, Line 24: // Test whether the method correctly searches and maps indexes of counters based : // on counter_name > I have added a test case where an error is thrown in case the counter is mi Ack -- To view, visit http://gerrit.cloudera.org:8080/20538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0caf0a0beee23821f78c0b3fe1aeb7dbf92d6a3e Gerrit-Change-Number: 20538 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 25 Oct 2023 19:33:48 +0000 Gerrit-HasComments: Yes
