Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20625
Change subject: IMPALA-12518: Combine all exec_option dimension in test_vector.py ...................................................................... IMPALA-12518: Combine all exec_option dimension in test_vector.py Before this patch, when writing pytest that exercise custom query option values, we need to declare it by making new test dimension, followed by deepcopying the original vector, and inserting the selected dimension value into 'exec_option' dictionary in generated vector. This patch simplify this steps by accounting dimensions that is intended to be part of 'exec_option' and automatically combining them during vector generation in test_vector.py. Such dimension should be registered via the new ImpalaTestMatrix.add_exec_option_dimension() function. function add_exec_option_dimension() in test_dimensions.py is renamed to add_mandatory_exec_option() to make it consistent with the same functionality in ImpalaTestMatrix and avoid confusion with the new ImpalaTestMatrix.add_exec_option_dimension() function. Function name add_exec_option_dimension() in test_dimensions.py is then repurposed as a shorthand for ImpalaTestMatrix.add_exec_option_dimension(). The remaining changes for other pytest files will be done gradually. Testing: - Fix bug in TestIcebergV2Table and confirm that both True and False value for 'disable_optimized_iceberg_v2_read' options are exercised. - Run and pass all modified tests in this patch. Change-Id: I3adba260990fccf4d2f2e7c8c4e4fadc6fd43fe1 --- M tests/common/test_dimensions.py M tests/common/test_vector.py M tests/custom_cluster/test_kudu.py M tests/query_test/test_async_codegen.py M tests/query_test/test_iceberg.py M tests/query_test/test_kudu.py M tests/query_test/test_runtime_filters.py 7 files changed, 86 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/20625/1 -- To view, visit http://gerrit.cloudera.org:8080/20625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3adba260990fccf4d2f2e7c8c4e4fadc6fd43fe1 Gerrit-Change-Number: 20625 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
