Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20367 )
Change subject: IMPALA-10976: Sync db/table in catalogD to latest HMS event id after the DDL operation for all DDLS from Impala clients ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20367/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20367/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1113 PS4, Line 1113: reloadMetadata = false; > reloadMetadata is set to false for addPartitions() -- https://gerrit.cloude alterTableAddPartitions() and alterTableDropPartition() already modify the cache in place since they invoke catalog_.addPartition or catalog_.dropPartitions(). Such modification based on current DDL request could conflict with applying the HMS events from external sources. I don't think we should change back to the original state. Instead, we should skip the part of updating the cache in place in alterTableAddPartitions() and alterTableDropPartition() when syncToLatestEventId is on. Only update the cache using MetastoreEventsProcessor.syncToLatestEventId(). Or prove that the current approach (updating the cache in place based on current DDL and then applying the pending HMS events) is correct for addPartitions and dropPartitions. -- To view, visit http://gerrit.cloudera.org:8080/20367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf Gerrit-Change-Number: 20367 Gerrit-PatchSet: 5 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 12:49:09 +0000 Gerrit-HasComments: Yes
