Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20617 )
Change subject: IMPALA-12515: Build modules for extra pythons ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20617/4/shell/CMakeLists.txt File shell/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/20617/4/shell/CMakeLists.txt@35 PS4, Line 35: # Tests depend on installing system pythons to specific locations. This doesn't work with make_shell_tarball.sh, which infers venvs from the EXEs. It'll usually work, since IMPALA_SYSTEM_PYTHON2/3 should map to python2/python3, but could be broken by overrides. -- To view, visit http://gerrit.cloudera.org:8080/20617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13720a9e3c50f348bef41f5e91f810204e416f13 Gerrit-Change-Number: 20617 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 23:25:37 +0000 Gerrit-HasComments: Yes
