Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20643 )
Change subject: IMPALA-12529: Show logs for the time of acquiring table/db locks ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20643/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/20643/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@534 PS1, Line 534: } > Should we keep LOG.trace for duration less than 100ms if LOG.isTraceEnabled I'm not sure whether this TRACE level log is useful. Mostly the lock is acquired within 1ms so "0 mesc" is printed. When we look into the catalogd logs, we are usually investigating slow or hanging operations. Such a short duration seems useless. -- To view, visit http://gerrit.cloudera.org:8080/20643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99d0665a5ab815a81a5341f63aff1ac2f9a447d5 Gerrit-Change-Number: 20643 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 12:38:28 +0000 Gerrit-HasComments: Yes
