Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20612 )
Change subject: IMPALA-3825: Delegate runtime filter aggregation to some executors ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/20612/8/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/20612/8/be/src/scheduling/scheduler.cc@312 PS8, Line 312: int num_agg = (int)ceil((double)instance_groups.size() / num_filters_per_host); This calculation is confusing me a little bit. I would expect it to read "total_number_of_filters / num_filters_per_host", with a cap of instance_groups.size(). I guess it works because the number of filters is really the number of filter sources (which would be the number of instances participating in the query, e.g. instance_groups.size()). Might be worth a comment reminding readers of that. http://gerrit.cloudera.org:8080/#/c/20612/8/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test File testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test: http://gerrit.cloudera.org:8080/#/c/20612/8/testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test@184 PS8, Line 184: # or exactly 1 if MAX_NUM_FILTERS_AGGREGATED_PER_HOST=2. The minicluster has 3 nodes, but this works because we exclude the coordinator. Right? -- To view, visit http://gerrit.cloudera.org:8080/20612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11d38ed0f223d6e5b32a19ebe725af7738ee4ab0 Gerrit-Change-Number: 20612 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Nov 2023 20:44:57 +0000 Gerrit-HasComments: Yes
