Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 )
Change subject: IMPALA-12493: Allow retry after failed cancel_query ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20584/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20584/5//COMMIT_MSG@21 PS5, Line 21: They were added : in IMPALA-10413 and IMPALA-10414 with no explanation why check inflight : was needed, and still pass their tests. I think the reason is the new query is marked as in-flight here: https://github.com/apache/impala/blob/39adf42a30765208e51e970339e950aae8544848/be/src/runtime/query-driver.cc#L341 So before that line, we shouldn't check in-flight. After that line, we can check in-flight. I'm ok to ignore the in-flight checks there since the state is obvious. http://gerrit.cloudera.org:8080/#/c/20584/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/20584/5/be/src/service/client-request-state.cc@1474 PS5, Line 1474: void ClientRequestState::Cancel( : const Status* cause, bool wait_until_finalized) { nit: can fit a single line -- To view, visit http://gerrit.cloudera.org:8080/20584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24 Gerrit-Change-Number: 20584 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:43:52 +0000 Gerrit-HasComments: Yes
