Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20367 )
Change subject: IMPALA-10976: Sync db/table to latest HMS event for all DDL/DMLs ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/20367/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20367/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-10976: Sync db/table to latest HMS event : for all DDL/DMLs : > nit: I think we can make it in one line and shorter, e.g. Ack http://gerrit.cloudera.org:8080/#/c/20367/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20367/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7040 PS4, Line 7040: try { : HdfsCachingUtil.removePartitionCacheDirective(part.getParameters()); : } catch (ImpalaException e1) { : String msg = String.format( : "Partition %s.%s(%s): State: Leaked caching directive. " + : "Action: Manually uncache directory %s via hdfs " + : "cacheAdmin.", part.getDbName(), part.getTableName(), : part.getValues(), part.getSd().getLocation()); : LOG.error(msg, e); : > Agree that we can keep invalidate as-is. For REFRESH, I think at least we s Ack http://gerrit.cloudera.org:8080/#/c/20367/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20367/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1145 PS6, Line 1145: if (refreshedTable != null) { > I think we should skip this as well when enableSyncToLatestEventOnDdls is o Ack http://gerrit.cloudera.org:8080/#/c/20367/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1185 PS6, Line 1185: if (refreshedTable != null) { > Same issue as L1145, this might reset the catalog version to an older one w Ack -- To view, visit http://gerrit.cloudera.org:8080/20367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia250d0a943838086c187e5cb7c60035e5a564bbf Gerrit-Change-Number: 20367 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Nov 2023 23:50:13 +0000 Gerrit-HasComments: Yes
