Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20691 )
Change subject: IMPALA-12552: Fix Kerberos authentication issue that occurs in python 3 environment when kerberos_host_fqdn option is used ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Please add some tests covering http://gerrit.cloudera.org:8080/#/c/20691/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/20691/1/shell/impala_client.py@451 PS1, Line 451: def _get_kerb_host_from_kerberos_host_fqdn(self): Can we add tests for this? Since we don't have Kerberos enabled, we might need to explore some sort of unit testing. -- To view, visit http://gerrit.cloudera.org:8080/20691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b157d76824ad67faf531a529256a8afe2ab9d49 Gerrit-Change-Number: 20691 Gerrit-PatchSet: 1 Gerrit-Owner: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Nov 2023 17:24:07 +0000 Gerrit-HasComments: Yes
