Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20689 )
Change subject: IMPALA-12550: Fix flaky test test_statestored_auto_failover_with_disabling_network ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/20689/4/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/20689/4/be/src/statestore/statestore.cc@1976 PS4, Line 1976: LOG(WARNING) << "Enter HA recovery mode."; > Good suggestion. Will change in the future. Added TODO here A couple places are accumulating several values that need to be set together. Pulling those out into helper functions would help avoid mistakes. Something else useful to think about when refactoring. -- To view, visit http://gerrit.cloudera.org:8080/20689 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I515bbaaddfb4bf9bd2a39414cd6e3e4590dfbfb1 Gerrit-Change-Number: 20689 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 09 Nov 2023 21:20:49 +0000 Gerrit-HasComments: Yes
