Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/20692/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20692/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-11542: Implement pre-allocation in LLVM memory manager > Can you add "llvm" to the title to make the scope clearer? Done http://gerrit.cloudera.org:8080/#/c/20692/4//COMMIT_MSG@12 PS4, Line 12: > Can you mention that this is an LLVM issue and that the Jira contains more Done http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.h File be/src/codegen/mcjit-mem-mgr.h: http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.h@83 PS4, Line 83: > Can you mention that these come from https://github.com/llvm/llvm-project/b I've split into multiple commits to make clear what's from the LLVM project. http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.cc File be/src/codegen/mcjit-mem-mgr.cc: http://gerrit.cloudera.org:8080/#/c/20692/4/be/src/codegen/mcjit-mem-mgr.cc@93 PS4, Line 93: : : : : : : : : : : : : > Can you mark somehow which functions is just a copy from llvm, and which on I've split commits up so it should be much clearer. -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 10 Nov 2023 16:30:54 +0000 Gerrit-HasComments: Yes
