Daniel Becker has uploaded a new patch set (#2). (
http://gerrit.cloudera.org:8080/20676 )
Change subject: IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table
properties
......................................................................
IMPALA-12333: SHOW CREATE TABLE outputs some unnecessary table properties
SHOW CREATE TABLE outputs some unnecessary table properties, some of
which are Iceberg-specific. This change removes the following table
properties from SHOW CREATE TABLE statements:
Iceberg-specific:
- previous_metadata_location
- current-schema
- snapshot-count
- current-snapshot-id
- current-snapshot-summary
- current-snapshot-timestamp-ms
- default-partition-spec
- uuid
General:
- numRows
- numFiles
- totalSize
- numFilesErasureCoded
- last_modified_by
- last_modified_time
- impala.events.catalogServiceId
- impala.events.catalogVersion
Testing:
- Added a test class in test_show_create_table.py,
TestShowCreateTableIcebergProperties, that tests that the above
Iceberg-specific table properties (and some others that occur with
Iceberg tables) are not included in SHOW CREATE TABLE statements.
- Modified test_show_create_table.py::TestShowCreateTable
- removed the above properties and some others that should not be
included in SHOW CREATE TABLE statements from the ignore list that
is used when comparing expected and actual SHOW CREATE TABLE
statements
- some of these previously ignored properties were listed among the
expected table properties in 'show-create-table.test', this change
removes them from there.
Change-Id: Id6f2cb9194f685a583b0d550532eb2454f119666
---
M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java
M fe/src/main/java/org/apache/impala/catalog/FeTable.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/show-create-table.test
M tests/metadata/test_show_create_table.py
6 files changed, 207 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/20676/2
--
To view, visit http://gerrit.cloudera.org:8080/20676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6f2cb9194f685a583b0d550532eb2454f119666
Gerrit-Change-Number: 20676
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
