Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20653 )
Change subject: IMPALA-12377: Improve count(*) performance for jdbc external table ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20653/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20653/2//COMMIT_MSG@10 PS2, Line 10: Even > nit: Even when there fixed http://gerrit.cloudera.org:8080/#/c/20653/2//COMMIT_MSG@11 PS2, Line 11: rows > nit: add rows fixed http://gerrit.cloudera.org:8080/#/c/20653/2/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/20653/2/be/src/exec/data-source-scan-node.cc@354 PS2, Line 354: // TODO Timezone depends on flag use_local_tz_for_unix_timestamp_conversions. > New comments look a bit weird as we break multiple times before reaching th Yes, try to avoid warning for exceeding 90 chars. Made the line short. -- To view, visit http://gerrit.cloudera.org:8080/20653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9953dca949eb773022f1d6dcf48d8877857635d6 Gerrit-Change-Number: 20653 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Tue, 14 Nov 2023 00:06:16 +0000 Gerrit-HasComments: Yes
