Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20723 )
Change subject: IMPALA-12571: Fix errors related to small strings found by Clang sanitizer builds ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20723/2/be/src/runtime/string-value.cc File be/src/runtime/string-value.cc: http://gerrit.cloudera.org:8080/#/c/20723/2/be/src/runtime/string-value.cc@39 PS2, Line 39: char* ptr = Ptr(); Could this be const? Also I'm not clear what issue this is fixing. -- To view, visit http://gerrit.cloudera.org:8080/20723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51d48b79bde0a5ae0103a780f9c09f3003ed157e Gerrit-Change-Number: 20723 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 22 Nov 2023 21:52:10 +0000 Gerrit-HasComments: Yes
