Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20673 )
Change subject: IMPALA-12486: Add catalog metrics for metadata loading ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20673/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/20673/2/common/thrift/metrics.json@350 PS2, Line 350: catalog. New metrics have "catalog." prefix, but label says "Catalog Server". Should they prefixed with "catalog-server." instead, like existing "catalog-server.topic-processing-time-s"? I think this warrant two new prefix: "catalog-server.metadata.file.xxx" "catalog-server.metadata.table.xxx" What do you think? -- To view, visit http://gerrit.cloudera.org:8080/20673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icef7b123bdcb0f5b8572635eeaacd8294990f9ba Gerrit-Change-Number: 20673 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 28 Nov 2023 17:50:38 +0000 Gerrit-HasComments: Yes
