Tim Armstrong has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4353/2/be/src/testutil/death-test-util.h File be/src/testutil/death-test-util.h: PS2, Line 41: setrlimit(RLIMIT_CORE, &limit); : : minidumps_enabled_before_ = EnableMinidumpsForTest(false); > I assume it's necessary to disable core dumps when we've disabled minidumps I'm not sure I understand the comment. The class is meant to disable both in tests, but I don't think there's a dependency between the two. The previous version of the class in promise-test.cc only disabled coredumps. http://gerrit.cloudera.org:8080/#/c/4353/3/be/src/util/minidump.h File be/src/util/minidump.h: PS3, Line 29: for death test > nit: maybe remove or reword like "for example during death test" or "during Done -- To view, visit http://gerrit.cloudera.org:8080/4353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33037f4f77c8188fc2ec46a77083a0a64f6ea404 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
