Michael Brown has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu ......................................................................
Patch Set 1: (2 comments) I'm still reviewing this, but since my name was called out, here are two comments. http://gerrit.cloudera.org:8080/#/c/4327/1/testdata/bin/load-tpc-kudu.py File testdata/bin/load-tpc-kudu.py: PS1, Line 50: with > Hm, I've seen other scripts (e.g. load_nested.py) already using the same s It's not clear to me that we have to support python2.4 in test code. If we do, then our test code is already broken in many, many places. I would prefer to set the floor for test code at python2.6, which is already inconveniently old. I'm OK to leave this as is. http://gerrit.cloudera.org:8080/#/c/4327/1/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: PS1, Line 1382: if not args.tpcds_db and not args.tpch_db and not args.random_db \ : and not args.tpch_nested_db and not args.tpch_kudu_db \ : and not args.tpcds_kudu_db and not args.query_file_path: : raise Exception("At least one of --tpcds-db, --tpch-db, --tpch-kudu-db," : "--tpcds-kudu-db, --tpch-nested-db, --random-db, --query-file-path is required") > Hmm cumbersome... Maybe someone with more python experience knows a better If not any() should work. https://docs.python.org/2.6/library/functions.html#any -- To view, visit http://gerrit.cloudera.org:8080/4327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9fc3dae24b761f031ee8e014bd611a49029d34 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
