Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. ......................................................................
Patch Set 11: (1 comment) Thanks for helping me fix the auditing bugs. I wish this wiki may help me get my local env working. https://cwiki.apache.org/confluence/display/IMPALA/How+to+load+and+run+Impala+tests http://gerrit.cloudera.org:8080/#/c/3942/11/fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java File fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java: Line 80: if (tableRef instanceof CollectionTableRef) { > Could you add a test for this? Is it possible for an AlterTableStmt getting a CollectionTableRef? -- To view, visit http://gerrit.cloudera.org:8080/3942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Amos Bird <amosb...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Amos Bird <amosb...@gmail.com> Gerrit-HasComments: Yes