Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4144/8/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: PS8, Line 1766: for (Partition partition: hmsPartitions) { : // Create and add the HdfsPartition. Return the table object with an updated : // catalog version. : addHdfsPartition(tbl, partition); : } > Correct, this is exactly what happens. I've added an E2E test (test_add_ove No, I don't think is the correct behavior. Actually I filed a JIRA (IMPALA-4141) about this case because it wasn't even working correctly for the single partition case. The right thing to do is to also add the partition in the catalog cache. If the user tries to add a partition he should get one of the two possible outcomes. Either an error is thrown and the partition is not added or no error and the partition is added. No error and no partition added is weird from a usability point of view. -- To view, visit http://gerrit.cloudera.org:8080/4144 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddbc951f2931f488f7048c9780260f6b49100750 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
