Lars Volker has posted comments on this change. Change subject: Make gen_build_version.py resilient to a failing git rev-parse ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4411/8/bin/save-version.sh File bin/save-version.sh: Line 24: VERSION=2.8.0-cdh5-INTERNAL > Was this the conflict? I think maybe it should be rolled back to 2.7.0. I agree with Jim. Here's the change that fixes this: http://gerrit.cloudera.org:8080/4439 -- To view, visit http://gerrit.cloudera.org:8080/4411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7af33502bbb70185dc15ffca6219436a616f25b Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes