Michael Brown has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions ......................................................................
Patch Set 3: (3 comments) Thanks for adding a test! http://gerrit.cloudera.org:8080/#/c/4419/3/tests/comparison/query_generator.py File tests/comparison/query_generator.py: Line 1364: ''' Add documentation about the signatures parameter. http://gerrit.cloudera.org:8080/#/c/4419/3/tests/comparison/query_profile.py File tests/comparison/query_profile.py: PS3, Line 661: if signature.func in (Equals, And): : allowed_join_signatures.append(signature) : elif len(signature.args) == 1: Maybe use an or expression for these two conditions and remove the elif? http://gerrit.cloudera.org:8080/#/c/4419/3/tests/comparison/tests/hive/test_create_join_clause.py File tests/comparison/tests/hive/test_create_join_clause.py: PS3, Line 31: class MockQueryProfile(HiveProfile): 1. I prefer "Fake" instead of "Mock". I prefer the use of "mock" only when using actual mock libraries. Is this reasonable? 2. Use Hive in the name, to explain it's a fake HiveProfile. -- To view, visit http://gerrit.cloudera.org:8080/4419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe8832a03cfa0d7ecc293ec6db6db2bcb34ab459 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: stak...@cloudera.com Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: stak...@cloudera.com Gerrit-HasComments: Yes
