Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4390/4/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: Line 387: AggFnEvaluator::Add(aggregate_evaluators_, agg_fn_ctxs_, row, tuple); > why is this change needed? shouldn't fn_ctxs always be the same as &this-> Yes, this is the same as this->agg_fn_ctxs_. The signature was changed for codegen but it has been undone in the latest version of the patch. http://gerrit.cloudera.org:8080/#/c/4390/5/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: PS5, Line 92: . nit: long line http://gerrit.cloudera.org:8080/#/c/4390/5/be/src/exec/partitioned-aggregation-node.cc File be/src/exec/partitioned-aggregation-node.cc: PS5, Line 164: . nit: long line. http://gerrit.cloudera.org:8080/#/c/4390/5/be/src/exec/partitioned-aggregation-node.h File be/src/exec/partitioned-aggregation-node.h: PS5, Line 478: . nit: extra full stop. -- To view, visit http://gerrit.cloudera.org:8080/4390 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42039eed803a39fa716b9ed647510b6440974ae5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
