Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit Message: Line 10: Purpose: Removes all instances of one or more characters from the > Please look at invisible_functions, line 672 of that file. Greetings, Jim. Thank you so much for providing this great idea. However, I am afraid I must say this approach doesn't work as it is intended to be. If I move the btrim entry to the invisible_functions part, both two syntaxes are unavailable now for these two syntaxes share the same entry. I have verified this by experiments. Please feel free to point out my mistake if you think I am wrong. Thank you. :) -- To view, visit http://gerrit.cloudera.org:8080/4474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4753c608b0b00569bf8c5e95b132df6df358e602 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Youwei Wang <youwei.a.w...@intel.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Youwei Wang <youwei.a.w...@intel.com> Gerrit-HasComments: Yes
