Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4555
Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options ...................................................................... IMPALA-4207: test infra: move Hive options from connection to cluster options Various test tools and frameworks, including the stress test, random query generator, and nested types loader, share common modules. This change IMPALA-3980: qgen: re-enable Hive as a target database made changes to tests.comparison.cli_options, the shared command line option module, and to tests.comparison.cluster, the shared module for modeling various Impala clusters. Those changes were for the random query generator, but didn't take into account the other shared entry points. It was possible to call some of those entry points in such a way as to produce an exception, because the Hive-related options are now required for miniclusters, but the Hive-related options weren't always being initialized in those entry points. The simple fix is to say that, because Hive settings are now needed to create Minicluster objects, make the Hive options initialized with cluster options, not connection options. While I was making these changes, I fixed flake8 problems in these methods only. Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b --- M tests/comparison/cli_options.py 1 file changed, 31 insertions(+), 22 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/4555/1 -- To view, visit http://gerrit.cloudera.org:8080/4555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a2915e6db85ddb3d8e1bce8035eccd0c9324b4b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com>
