Tim Armstrong has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: Line 78: SeedOpenSSLRNG(); > Concern was not really about perf, but about making the behavior as simple/ I added a mention that it's global in the method comment. http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/util/openssl-util.h File be/src/util/openssl-util.h: Line 35: public: > How can you be sure the verification will fail? It seems like there's a rem The chance of a random collision like that happening with SHA-256 is 1/2^256 The probability of an bool/DCHECK is even lower since it only help if a) we exercise the bad code path when running in debug mode (i.e. in our regular testing) and b) every time we exercise the code path we have a hash collision. -- To view, visit http://gerrit.cloudera.org:8080/4389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibebe431f69c3c569cbff68171beaa32ef2ab03b6 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
