Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load ......................................................................
Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/4519/4/be/src/rpc/TAcceptQueueServer.cpp File be/src/rpc/TAcceptQueueServer.cpp: PS4, Line 136: SetupCon > doAccept() isn't a great name (I know it was from my patch!) because this i Done PS4, Line 204: rift code > connection_handler_pool, or something similar. Done PS4, Line 205: texpr int CONNECTION_SE > This can be defined in this method as a constexpr. Done http://gerrit.cloudera.org:8080/#/c/4519/4/be/src/rpc/TAcceptQueueServer.h File be/src/rpc/TAcceptQueueServer.h: PS4, Line 96: New - > strange line breaks in this comment. Done PS4, Line 97: // up the connection and starting a thread to > move into .cc file Done http://gerrit.cloudera.org:8080/#/c/4519/4/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: PS4, Line 173: ManyConcurrent > Call this ManyConcurrentConnection or something. Done Line 175: // waiting to be accepted. (IMPALA-4135) > Mention that this does not always fail. How long does it take to run? It takes about 2 seconds on my machine. -- To view, visit http://gerrit.cloudera.org:8080/4519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie50e728974ef31a9d49132a0b3f7cde2a4f3356d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Juan Yu <j...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
