Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4076: Fix runtime filter sort compare method ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4652/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: Line 341: } > Sorry, I confused myself (and the join sides). You are right. Please leave Done http://gerrit.cloudera.org:8080/#/c/4652/2/testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test File testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test: Line 1123: # constructed by hand to trigger the issue with the sort compare method violating the > You are right, let's remove setting the query option in PlannerTest, sorry. Ok, removed. -- To view, visit http://gerrit.cloudera.org:8080/4652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad433f2ece423ea29e79e81b68fa53cb0af18378 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
