Alex Behm has posted comments on this change. Change subject: IMPALA-3943: Do not throw scan errors for empty Parquet files. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4693/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 250: succeeds without errors irrespective of abort_on_error.""" > why even mention abort_on_error? i think that's still a legal parquet file. Removed. Line 256: check_call(['hdfs', 'dfs', '-copyFromLocal', > out of scope, but would be better to have this set up as a permanent table Agree, out of scope. I think it is also debatable. Imo, it's better for test infra stability to have have such one-off tables be self-contained in the test without "polluting" the snapshot and data loading paths. Think about it this way: Adding to the functional suite would require much more script/conf changes in several different files and potentially cause hiccups with stale snapshots. Doesn't seem worth it if only this single test needs those files. -- To view, visit http://gerrit.cloudera.org:8080/4693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50ac3df6ff24bc5c384ef22e0f804a5132adb62e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
