David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes ......................................................................
Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/4678/5//COMMIT_MSG Commit Message: PS5, Line 10: use Would "mount" be an appropriate verb. If so, I think it's more descriptive. PS5, Line 19: need the "need to move the"? PS5, Line 21: rsync Why rsync versus, say, just cp or mv? http://gerrit.cloudera.org:8080/#/c/4678/5/tests/comparison/leopard/README File tests/comparison/leopard/README: PS5, Line 17: Basic Configuration It's a nit, but it might be nicer if this line, and "External Volume Configuration" below, looked a little more like headers. PS5, Line 43: use "mount external Docker volumes that contain the necessary testdata"? PS5, Line 54: path on TARGET_HOST where the : external volume will reside This is just a directory, right? http://gerrit.cloudera.org:8080/#/c/4678/5/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: Line 298: if os.environ.get('KUDU_IS_SUPPORTED') == 'true': Does it makes sense to reference KUDU-1419 here, or at least the README, to explain why the extra work is being done? Line 308: 'rsync -e "ssh -i {priv_key} -o StrictHostKeyChecking=no ' I'm just curious -- how long does this process take? -- To view, visit http://gerrit.cloudera.org:8080/4678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d9d9253fcd7e3905e389ddeb1438cee3e24480 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
