Michael Ho has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() ......................................................................
Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hash-join-node.cc File be/src/exec/hash-join-node.cc: Line 172: Function* codegen_process_probe_batch_fn = CodegenProcessProbeBatch(codegen, hash_fn); > Long line. Done http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 622: return Status("Disabled by query option."); > Dead code I think. Done http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: Line 153: Status HdfsScanNodeBase::Prepare(RuntimeState* state) { > It doesn't look like we add the codegen disabled message hre. Done http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 700: return Status("Disabled by query option."); > Dead code? Done http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exprs/scalar-fn-call.cc File be/src/exprs/scalar-fn-call.cc: PS3, Line 49: #define MAX_INTERP_ARGS 20 > Comments added in the next patch. Done Line 562: #define ARG_DECL_LIST(n) \ > Thanks for doing this. Done PS3, Line 574: MAX_INTERP_ARGS > MAX_INTERP_ARGS+1 Done PS3, Line 592: MAX_INTERP_ARGS > MAX_INTERP_ARGS+1 Done http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 104: state.CreateCodegen(), env, JniUtil::internal_exc_class(), result_bytes); > Tab? Done -- To view, visit http://gerrit.cloudera.org:8080/4651 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207566bc9f4c6a159271ecdbc4bbdba3d78c6651 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
