David Knupp has posted comments on this change. Change subject: IMPALA-4294: Execute data load steps from within git repo. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4726/2/buildall.sh File buildall.sh: PS2, Line 431: # Data loading relies upon comparing git hashes, so we need to make sure : # we're executing from within the context of the Impala repo directory. : pushd "${IMPALA_HOME}" : load_test_data : popd > Ok, how about adding Does this work for you? It doesn't seem to work for me. I get different results based upon where I call the script. >From outside the repo: ~ $ git --git-dir ${IMPALA_HOME}/.git diff --exit-code a9c4059..HEAD ${IMPALA_HOME}/testdata/datasets/$DATASET ~ $ echo $? 0 >From inside the repo: ~ $ cd Impala ~/Impala (IMPALA_4294) $ git diff --exit-code a9c4059..HEAD ${IMPALA_HOME}/testdata/datasets/$DATASET diff --git a/testdata/datasets/functional/schema_constraints.csv b/testdata/datasets/functional/schema_constraints.csv index a22a432..4c9da6d 100644 --- a/testdata/datasets/functional/schema_constraints.csv +++ b/testdata/datasets/functional/schema_constraints.csv @@ -123,7 +123,7 @@ table_name:widerow, constraint:exclude, table_format:hbase/none/none table_name:nullformat_custom, constraint:exclude, table_format:hbase/none/none table_name:unsupported_types, constraint:exclude, table_format:hbase/none/none -# On CDH4, decimal can only be tested on formats Impala can write to (text and parquet) +# Decimal can only be tested on formats Impala can write to (text and parquet). # TODO: add Avro once Hive or Impala can write Avro decimals table_name:decimal_tbl, constraint:restrict_to, table_format:text/none/none table_name:decimal_tiny, constraint:restrict_to, table_format:text/none/none ~/Impala (IMPALA_4294) $ echo $? 1 -- To view, visit http://gerrit.cloudera.org:8080/4726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32e0dce2c10c443763a038aa3b64b1c123ed62ad Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
