Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4736/2//COMMIT_MSG Commit Message: Line 7: IMPALA-2905: Move QueryResultSet implementations into separate module > Is this the right JIRA? IMPALA-2905 is fixed. It was suggested in the 2905 review, where half the work was done. Didn't see a lot of point making a new JIRA. http://gerrit.cloudera.org:8080/#/c/4736/2/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: PS2, Line 500: ( > nit: extraneous parens. Done http://gerrit.cloudera.org:8080/#/c/4736/2/be/src/service/query-result-set.h File be/src/service/query-result-set.h: Line 27: #include <boost/scoped_ptr.hpp> > what for? Done -- To view, visit http://gerrit.cloudera.org:8080/4736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ab883b62d3ec7012240edf8d56889349e7c0e32 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes
