Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4327/6/testdata/datasets/tpcds/tpcds_kudu_template.sql File testdata/datasets/tpcds/tpcds_kudu_template.sql: PS6, Line 4: ---- TODO: Remove the IS NOT NULL predicates when nullable keys are supported > I haven't verified the data and in theory PK columns shouldn't have nulls. That sounds like a bunch of work-- If you don't think there are any nulls, seems easiest to remove it and kick off a test run? While it doesn't really matter for us when we just throw a lot of queries at the system, I'm just worried we could start using these tables for other things at some point later and get ourselves into trouble. -- To view, visit http://gerrit.cloudera.org:8080/4327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9fc3dae24b761f031ee8e014bd611a49029d34 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
