Alex Behm has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4732/4/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: Line 771: > An alternative to having to check *_IGNORE_NULLS here and in analyze() is t Thanks for the suggestion! I like your version better. Done. PS4, Line 772: fnCall_.setIsAnalyticFnCall(true); : fnCall_.setIsInternalFnCall(true); : fnCall_.analyzeNoThrow(analyzer); : analyticFnName = getFnCall().getFnName(); : Preconditions.checkState(type_.equals(fnCall_.getType())); > not a real problem, but we'll re-execute this. that won't happen if we unse Done -- To view, visit http://gerrit.cloudera.org:8080/4732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I708de7925fe6aeef582fd7510da93d24c71229d9 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
