Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate ......................................................................
Patch Set 2: (3 comments) Thanks for adding the test. Almost good to be merged. http://gerrit.cloudera.org:8080/#/c/4753/2/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: Line 102: # Subquery with predicate in the WHERE clause For bugfixes we comment tests like this: IMPALA-4325: Preserve parenthesis of expressions when rewriting subqueries. Line 106: select t2.int_col remove tab Line 108: where (t2.int_col is not null and (t2.int_col < 0 or t2.int_col > 10) or t2.bigint_col is not null and (t2.bigint_col < 0 or t2.bigint_col > 10)) please chop this up into multiple lines, nicely formatted -- To view, visit http://gerrit.cloudera.org:8080/4753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79bfc67605206e0e026293bf7032a88227a95623 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yuanhao Luo <luoyuan...@software.ict.ac.cn> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-HasComments: Yes
