Tim Armstrong has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/1/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: PS1, Line 91: file_name = "{0}-{1}-{2}-{3}.tar.gz".format(product, version, compiler, label) : url_path = "/{0}/{1}/{2}-{3}/{1}-{2}-{3}-{4}.tar.gz".format(toolchain_build_id, product, : version, compiler, label) > Would you be agreeable to using kwargs in str.format()? That would allow yo Good idea. -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcc25ae82511713d0ff05ded37ef162925f2f0fb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
