Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-3552: make incremental stats max serialized size 
configurable
......................................................................


Patch Set 1:

@Yonghyun I had a chat with Alex on the best way to move forward. He seems to 
agree with using BackendConfig to pass the params. As per our discussion, its 
better if we create a thrift struct (ex: TBackendConfig or some such similar), 
serialize it and pass it using JNI, unpack it in the JniCatalog/Frontend and 
populate it in a map in the static BackendConfig class. We could have getter 
methods that return the appropriated type cast'ed value corresponding to a 
given config key. You could clean up all the existing config arguments too 
using this.

-- 
To view, visit http://gerrit.cloudera.org:8080/4772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d189ffc1c56e7a4e27e6233e9119250a2395a19
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Yonghyun Hwang <yongh...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Huaisi Xu <h...@cloudera.com>
Gerrit-Reviewer: Yonghyun Hwang
Gerrit-HasComments: No

Reply via email to