Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4756/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS5, Line 801: o handle i > I had suggested moving it to be closer to the register call if this is call Done http://gerrit.cloudera.org:8080/#/c/4756/5/be/src/service/query-exec-state.h File be/src/service/query-exec-state.h: Line 157: > Blank line before this. Done Line 159: /// been created and had the pool set yet, or this StmtType doesn't go through admission > missing / Done PS5, Line 161: ol() > nullptr Done -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-HasComments: Yes
