Henry Robinson has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool ......................................................................
Patch Set 6: > I rearranged them all. Tim convinced me to roll some back. That doesn't really answer my question - given the current state of the patch, what are the criteria we should use, going forward, to decide whether a class should be CacheAligned? I suggest we reserve CacheAligned / grouping for classes that really need it, given the reduction in comprehension. Or am I underestimating how big the impact of properly aligning even non-performance critical classes will be? -- To view, visit http://gerrit.cloudera.org:8080/4758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ed168488cb30ddeccd0087f3840541d858f9c06 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No
