Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3724: Support Kudu non-covering range partitions ......................................................................
Patch Set 2: (1 comment) Just flushing out one comment. Working on the rest of the comments. http://gerrit.cloudera.org:8080/#/c/4856/2/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: Line 355: 2: optional ExternalDataSource.TComparisonOp lower_bound_op > Seems weird to reference ExternalDataSource here. Wouldn't a bool be suffic But this is where TComparisonOp leaves (which I agree is weird). We need to represent <, <= and =, so just a boolean is not enough, we need two. Let me know if you prefer that over what we have now. -- To view, visit http://gerrit.cloudera.org:8080/4856 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6799c01a37003f0f4c068d911a13e3f060110a06 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-HasComments: Yes
