Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4379: Fix and test Kudu table type checking ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4857/2/testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test File testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test: Line 46: ImpalaRuntimeException: Table 'simple_new' does not represent a Kudu table. Expected storage_handler 'com.cloudera.kudu.hive.KuduStorageHandler' but found 'foo' > Agree, I'm inclined to disallow altering storage handlers altogether. Why n They have weird behavior that I think is bad too. It doesn't allow you to use ALTER TABLE for any non-native tables. For native tables, it allows you to set storage_handler, but that will make the table a non-native table and then it can't be changed or even dropped. hive> alter table i1740_alter set tblproperties ('storage_handler'=''); OK Time taken: 0.132 seconds hive> alter table i1740_alter set tblproperties ('storage_handler'='foo'); FAILED: SemanticException [Error 10134]: ALTER TABLE cannot be used for a non-native table i1740_alter After this, nothing works on this table. I think I'll have to go to Mysql to drop it. -- To view, visit http://gerrit.cloudera.org:8080/4857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I475273cbbf4110db8d0f78ddf9a56abfc6221e3e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
