Tim Armstrong has posted comments on this change. Change subject: IMPALA-4223: Handle truncated file read from HDFS cache ......................................................................
Patch Set 1: Code-Review+1 Change looks good to me, I'm not convinced this was the problem we hit in IMPALA-4223 though, because it would not have made it this far when there was an error seeking in Open(). I think there's some protection against opening the wrong version of a HDFS file because the mtime of the cached file is checked (this check is definitely a good idea though) -- To view, visit http://gerrit.cloudera.org:8080/4828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1e1fdb0211819c5938956abb13b512350a46f1a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No
